sec: digest-pin Dockerfile.test base image (follow-up to #421) · Issue #1007 · LeanerCloud/cloud-commitments-cli · GitHub
Skip to content

sec: digest-pin Dockerfile.test base image (follow-up to #421) #1007

Closed

Description

@cristim

Summary

Follow-up to #421 (which digest-pinned Dockerfile.dev). Dockerfile.test still uses the unpinned tag golang:1.25.4-alpine3.21 (Dockerfile.test:6) and carries the same "Pin to SHA256 digest" TODO (line 4). The same supply-chain risk #421 addressed for the dev image applies to the test image.

Acceptance criteria

  • Pin Dockerfile.test FROM to the same golang:1.25.4-alpine3.21@sha256:3289aac...58b33 digest already used by Dockerfile + Dockerfile.dev (keep the human-readable tag inline + a dated refresh comment).
  • Remove the stale TODO.

Activity

  1. cristim commented on Jul 27, 2026

    @cristim
    MemberAuthor

    Verification sweep against main (101f099fb) on 2026-07-27 finds this already resolved.
    Dockerfile.test is digest-pinned to golang:1.26.5-alpine3.24, later bumped further.
    Evidence: Dockerfile.test:7; follow-up bump a840ed1.
    Recommending close.

  2. cristim commented on Sep 2, 2026

    @cristim
    MemberAuthor

    Verified resolved at 3c0f8ac: Dockerfile.test pins its base image by digest (golang:1.26.6-alpine3.24@sha256:3889b425...) and the stale TODO is removed. Evidence: Dockerfile.test:8 (first pinned in commit 877653d, kept aligned by a840ed1 and #1833). Residual axes checked: Dockerfile:18 and Dockerfile.dev:8 use the identical digest, so the three Go images are in lockstep. Closing as completed; reopen if the behaviour recurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions