FilesExpand file tree

 main

/

InefficientKeySetIterator.java

Copy path

Blame

More file actions

Blame

More file actions

Latest commit

 

History

History

History

25 lines (24 loc) · 696 Bytes

 main

/

InefficientKeySetIterator.java

Copy path

Top

File metadata and controls

• Code
• Blame

25 lines (24 loc) · 696 Bytes

Raw

Copy raw file

Download raw file

Open symbols panel

Edit and raw actions

1

2

3

4

5

6

7

8

9

10

11

12

13

14

15

16

17

18

19

20

21

22

23

24

25

// AVOID: Iterate the map using the key set.

class AddressBook {

private Map<String, Person> people = ...;

public String findId(String first, String last) {

for (String id : people.keySet()) {

Person p = people.get(id);

if (first.equals(p.firstName()) && last.equals(p.lastName()))

return id;

}

return null;

}

}

// GOOD: Iterate the map using the entry set.

class AddressBook {

private Map<String, Person> people = ...;

public String findId(String first, String last) {

for (Entry<String, Person> entry: people.entrySet()) {

Person p = entry.getValue();

if (first.equals(p.firstName()) && last.equals(p.lastName()))

return entry.getKey();

}

return null;

}

}