Shared: Move shared logic into `FlowSummaryImpl.qll` · Killpit/codeql@fbeb6f3 · GitHub
Skip to content

Commit fbeb6f3

Browse files
committed
Shared: Move shared logic into FlowSummaryImpl.qll
1 parent 395901b commit fbeb6f3

5 files changed

Lines changed: 16 additions & 20 deletions

File tree

‎csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowPrivate.qll‎

Lines changed: 3 additions & 5 deletions

‎java/ql/lib/semmle/code/java/dataflow/internal/DataFlowUtil.qll‎

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -160,11 +160,8 @@ predicate localMustFlowStep(Node node1, Node node2) {
160160
or
161161
node2.asExpr().(AssignExpr).getSource() = node1.asExpr()
162162
or
163-
node1 =
164-
unique(FlowSummaryNode n1 |
165-
FlowSummaryImpl::Private::Steps::summaryLocalStep(n1.getSummaryNode(),
166-
node2.(FlowSummaryNode).getSummaryNode(), true, _)
167-
)
163+
FlowSummaryImpl::Private::Steps::summaryLocalMustFlowStep(node1.(FlowSummaryNode).getSummaryNode(),
164+
node2.(FlowSummaryNode).getSummaryNode())
168165
}
169166

170167
import Cached

‎ruby/ql/lib/codeql/ruby/dataflow/internal/DataFlowPrivate.qll‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -175,11 +175,9 @@ module LocalFlow {
175175
or
176176
node1 = node2.(ImplicitBlockArgumentNode).getParameterNode(true)
177177
or
178-
node1 =
179-
unique(FlowSummaryNode n1 |
180-
FlowSummaryImpl::Private::Steps::summaryLocalStep(n1.getSummaryNode(),
181-
node2.(FlowSummaryNode).getSummaryNode(), true, _)
182-
)
178+
FlowSummaryImpl::Private::Steps::summaryLocalMustFlowStep(node1
179+
.(FlowSummaryNode)
180+
.getSummaryNode(), node2.(FlowSummaryNode).getSummaryNode())
183181
}
184182
}
185183

‎rust/ql/lib/codeql/rust/dataflow/internal/DataFlowImpl.qll‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1030,11 +1030,9 @@ module RustDataFlow implements InputSig<Location> {
10301030
predicate localMustFlowStep(Node node1, Node node2) {
10311031
SsaFlow::localMustFlowStep(_, node1, node2)
10321032
or
1033-
node1 =
1034-
unique(Node::FlowSummaryNode n1 |
1035-
FlowSummaryImpl::Private::Steps::summaryLocalStep(n1.getSummaryNode(),
1036-
node2.(Node::FlowSummaryNode).getSummaryNode(), true, _)
1037-
)
1033+
FlowSummaryImpl::Private::Steps::summaryLocalMustFlowStep(node1
1034+
.(Node::FlowSummaryNode)
1035+
.getSummaryNode(), node2.(Node::FlowSummaryNode).getSummaryNode())
10381036
}
10391037

10401038
class LambdaCallKind = Void;

‎shared/dataflow/codeql/dataflow/internal/FlowSummaryImpl.qll‎

Lines changed: 5 additions & 0 deletions

0 commit comments

Comments
 (0)