Fix clazy-connect-by-name warnings · JC3/sqlitebrowser@7ad6063 · GitHub
Skip to content

Commit 7ad6063

Browse files
MKleusbergMKleusberg
committed
Fix clazy-connect-by-name warnings
1 parent b76f6a6 commit 7ad6063

18 files changed

Lines changed: 303 additions & 67 deletions

‎src/AddRecordDialog.cpp‎

Lines changed: 1 addition & 1 deletion

‎src/AddRecordDialog.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ private slots:
4040
void accept() override;
4141
void itemChanged(QTreeWidgetItem* item, int column);
4242
void help();
43-
void on_buttonBox_clicked(QAbstractButton* button);
43+
void buttonBoxClicked(QAbstractButton* button);
4444

4545
private:
4646
Ui::AddRecordDialog* ui;

‎src/AddRecordDialog.ui‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@
139139
<sender>buttonBox</sender>
140140
<signal>clicked(QAbstractButton*)</signal>
141141
<receiver>AddRecordDialog</receiver>
142-
<slot>on_buttonBox_clicked(QAbstractButton*)</slot>
142+
<slot>buttonBoxClicked(QAbstractButton*)</slot>
143143
<hints>
144144
<hint type="sourcelabel">
145145
<x>324</x>
@@ -153,6 +153,6 @@
153153
</connection>
154154
</connections>
155155
<slots>
156-
<slot>itemChanged()</slot>
156+
<slot>buttonBoxClicked(QAbstractButton*)</slot>
157157
</slots>
158158
</ui>

‎src/CondFormatManager.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ void CondFormatManager::itemClicked(QTreeWidgetItem* item, int column)
236236
}
237237
}
238238

239-
void CondFormatManager::on_buttonBox_clicked(QAbstractButton* button)
239+
void CondFormatManager::buttonBoxClicked(QAbstractButton* button)
240240
{
241241
if (button == ui->buttonBox->button(QDialogButtonBox::Cancel))
242242
reject();

‎src/CondFormatManager.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ private slots:
4747
void moveItem(int offset);
4848
void upItem();
4949
void downItem();
50-
void on_buttonBox_clicked(QAbstractButton* button);
50+
void buttonBoxClicked(QAbstractButton* button);
5151

5252
public slots:
5353
void itemClicked(QTreeWidgetItem* item, int column);

‎src/CondFormatManager.ui‎

Lines changed: 9 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -245,35 +245,22 @@
245245
<connections>
246246
<connection>
247247
<sender>buttonBox</sender>
248-
<signal>accepted()</signal>
248+
<signal>clicked(QAbstractButton*)</signal>
249249
<receiver>CondFormatManager</receiver>
250-
<slot>accept()</slot>
250+
<slot>buttonBoxClicked(QAbstractButton*)</slot>
251251
<hints>
252252
<hint type="sourcelabel">
253-
<x>248</x>
254-
<y>254</y>
253+
<x>374</x>
254+
<y>377</y>
255255
</hint>
256256
<hint type="destinationlabel">
257-
<x>157</x>
258-
<y>274</y>
259-
</hint>
260-
</hints>
261-
</connection>
262-
<connection>
263-
<sender>buttonBox</sender>
264-
<signal>rejected()</signal>
265-
<receiver>CondFormatManager</receiver>
266-
<slot>reject()</slot>
267-
<hints>
268-
<hint type="sourcelabel">
269-
<x>316</x>
270-
<y>260</y>
271-
</hint>
272-
<hint type="destinationlabel">
273-
<x>286</x>
274-
<y>274</y>
257+
<x>374</x>
258+
<y>199</y>
275259
</hint>
276260
</hints>
277261
</connection>
278262
</connections>
263+
<slots>
264+
<slot>buttonBoxClicked(QAbstractButton*)</slot>
265+
</slots>
279266
</ui>

‎src/MainWindow.cpp‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2419,13 +2419,13 @@ void MainWindow::checkNewVersion(const QString& versionstring, const QString& ur
24192419
}
24202420
}
24212421

2422-
void MainWindow::on_actionWiki_triggered() const
2422+
void MainWindow::openLinkWiki() const
24232423
{
24242424
QDesktopServices::openUrl(QUrl("https://github.com/sqlitebrowser/sqlitebrowser/wiki"));
24252425
}
24262426

24272427
// 'Help | Bug Report...' link will set an appropriate body, add the system information and set the label 'bug' automatically to the issue
2428-
void MainWindow::on_actionBug_report_triggered() const
2428+
void MainWindow::openLinkBugReport() const
24292429
{
24302430
const QString version = Application::versionString();
24312431
const QString os = QSysInfo::prettyProductName();
@@ -2464,7 +2464,7 @@ void MainWindow::on_actionBug_report_triggered() const
24642464
}
24652465

24662466
// 'Help | Feature Request...' link will set an appropriate body and add the label 'enhancement' automatically to the issue
2467-
void MainWindow::on_actionFeature_Request_triggered() const
2467+
void MainWindow::openLinkFeatureRequest() const
24682468
{
24692469
QUrlQuery query;
24702470

@@ -2478,17 +2478,17 @@ void MainWindow::on_actionFeature_Request_triggered() const
24782478
QDesktopServices::openUrl(url);
24792479
}
24802480

2481-
void MainWindow::on_actionSqlCipherFaq_triggered() const
2481+
void MainWindow::openLinkSqlCipherFaq() const
24822482
{
24832483
QDesktopServices::openUrl(QUrl("https://discuss.zetetic.net/c/sqlcipher/sqlcipher-faq"));
24842484
}
24852485

2486-
void MainWindow::on_actionWebsite_triggered() const
2486+
void MainWindow::openLinkWebsite() const
24872487
{
24882488
QDesktopServices::openUrl(QUrl("https://sqlitebrowser.org"));
24892489
}
24902490

2491-
void MainWindow::on_actionDonatePatreon_triggered() const
2491+
void MainWindow::openLinkDonatePatreon() const
24922492
{
24932493
QDesktopServices::openUrl(QUrl("https://www.patreon.com/bePatron?u=11578749"));
24942494
}

‎src/MainWindow.h‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -202,12 +202,12 @@ private slots:
202202
void saveSqlResultsAsView();
203203
void loadExtension();
204204
void checkNewVersion(const QString& versionstring, const QString& url);
205-
void on_actionWiki_triggered() const;
206-
void on_actionBug_report_triggered() const;
207-
void on_actionFeature_Request_triggered() const;
208-
void on_actionSqlCipherFaq_triggered() const;
209-
void on_actionWebsite_triggered() const;
210-
void on_actionDonatePatreon_triggered() const;
205+
void openLinkWiki() const;
206+
void openLinkBugReport() const;
207+
void openLinkFeatureRequest() const;
208+
void openLinkSqlCipherFaq() const;
209+
void openLinkWebsite() const;
210+
void openLinkDonatePatreon() const;
211211
bool loadProject(QString filename = QString(), bool readOnly = false);
212212
void saveProject();
213213
void saveProjectAs();

‎src/MainWindow.ui‎

Lines changed: 102 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3750,6 +3750,102 @@ You can drag SQL statements from the Schema column and drop them into the SQL ed
37503750
</hint>
37513751
</hints>
37523752
</connection>
3753+
<connection>
3754+
<sender>actionWiki</sender>
3755+
<signal>triggered()</signal>
3756+
<receiver>MainWindow</receiver>
3757+
<slot>openLinkWiki()</slot>
3758+
<hints>
3759+
<hint type="sourcelabel">
3760+
<x>-1</x>
3761+
<y>-1</y>
3762+
</hint>
3763+
<hint type="destinationlabel">
3764+
<x>-1</x>
3765+
<y>-1</y>
3766+
</hint>
3767+
</hints>
3768+
</connection>
3769+
<connection>
3770+
<sender>actionBug_report</sender>
3771+
<signal>triggered()</signal>
3772+
<receiver>MainWindow</receiver>
3773+
<slot>openLinkBugReport()</slot>
3774+
<hints>
3775+
<hint type="sourcelabel">
3776+
<x>-1</x>
3777+
<y>-1</y>
3778+
</hint>
3779+
<hint type="destinationlabel">
3780+
<x>-1</x>
3781+
<y>-1</y>
3782+
</hint>
3783+
</hints>
3784+
</connection>
3785+
<connection>
3786+
<sender>actionFeature_Request</sender>
3787+
<signal>triggered()</signal>
3788+
<receiver>MainWindow</receiver>
3789+
<slot>openLinkFeatureRequest()</slot>
3790+
<hints>
3791+
<hint type="sourcelabel">
3792+
<x>-1</x>
3793+
<y>-1</y>
3794+
</hint>
3795+
<hint type="destinationlabel">
3796+
<x>-1</x>
3797+
<y>-1</y>
3798+
</hint>
3799+
</hints>
3800+
</connection>
3801+
<connection>
3802+
<sender>actionSqlCipherFaq</sender>
3803+
<signal>triggered()</signal>
3804+
<receiver>MainWindow</receiver>
3805+
<slot>openLinkSqlCipherFaq()</slot>
3806+
<hints>
3807+
<hint type="sourcelabel">
3808+
<x>-1</x>
3809+
<y>-1</y>
3810+
</hint>
3811+
<hint type="destinationlabel">
3812+
<x>-1</x>
3813+
<y>-1</y>
3814+
</hint>
3815+
</hints>
3816+
</connection>
3817+
<connection>
3818+
<sender>actionWebsite</sender>
3819+
<signal>triggered()</signal>
3820+
<receiver>MainWindow</receiver>
3821+
<slot>openLinkWebsite()</slot>
3822+
<hints>
3823+
<hint type="sourcelabel">
3824+
<x>-1</x>
3825+
<y>-1</y>
3826+
</hint>
3827+
<hint type="destinationlabel">
3828+
<x>-1</x>
3829+
<y>-1</y>
3830+
</hint>
3831+
</hints>
3832+
</connection>
3833+
<connection>
3834+
<sender>actionDonatePatreon</sender>
3835+
<signal>triggered()</signal>
3836+
<receiver>MainWindow</receiver>
3837+
<slot>openLinkDonatePatreon()</slot>
3838+
<hints>
3839+
<hint type="sourcelabel">
3840+
<x>-1</x>
3841+
<y>-1</y>
3842+
</hint>
3843+
<hint type="destinationlabel">
3844+
<x>-1</x>
3845+
<y>-1</y>
3846+
</hint>
3847+
</hints>
3848+
</connection>
37533849
</connections>
37543850
<slots>
37553851
<slot>fileOpen()</slot>
@@ -3812,5 +3908,11 @@ You can drag SQL statements from the Schema column and drop them into the SQL ed
38123908
<slot>renameTableBrowserTab(int)</slot>
38133909
<slot>showContextMenuTableBrowserTabBar(QPoint)</slot>
38143910
<slot>newRowCountsTab()</slot>
3911+
<slot>openLinkWiki()</slot>
3912+
<slot>openLinkBugReport()</slot>
3913+
<slot>openLinkFeatureRequest()</slot>
3914+
<slot>openLinkSqlCipherFaq()</slot>
3915+
<slot>openLinkWebsite()</slot>
3916+
<slot>openLinkDonatePatreon()</slot>
38153917
</slots>
38163918
</ui>

‎src/PlotDock.cpp‎

Lines changed: 5 additions & 6 deletions

0 commit comments

Comments
 (0)