Fix some warnings from LGTM (#2420) · Ilgrim/Algorithms-Python@20e98fc · GitHub
Skip to content

Commit 20e98fc

Browse files
Hasenncclauss
Hasenn
and
cclauss
authored
Fix some warnings from LGTM (TheAlgorithms#2420)
* fix assignment of a variable to itself * Fix unnecessary 'else' clause in loop * formatting and redundant reasignment fix * mark unreachable code with a TODO comment * fix variable defined multiple times * fix static method without static decorator * revert unintended autoformatting Co-authored-by: Christian Clauss <cclauss@me.com> * revert autoformatting issue * applied black autoformatting Co-authored-by: Christian Clauss <cclauss@me.com>
1 parent f754c0d commit 20e98fc

6 files changed

Lines changed: 9 additions & 6 deletions

File tree

‎ciphers/enigma_machine2.py‎

Lines changed: 0 additions & 1 deletion

‎graphs/directed_and_undirected_(weighted)_graph.py‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -226,6 +226,7 @@ def has_cycle(self):
226226
break
227227
else:
228228
return True
229+
# TODO:The following code is unreachable.
229230
anticipating_nodes.add(stack[len_stack_minus_one])
230231
len_stack_minus_one -= 1
231232
if visited.count(node[1]) < 1:
@@ -453,6 +454,8 @@ def has_cycle(self):
453454
break
454455
else:
455456
return True
457+
# TODO: the following code is unreachable
458+
# is this meant to be called in the else ?
456459
anticipating_nodes.add(stack[len_stack_minus_one])
457460
len_stack_minus_one -= 1
458461
if visited.count(node[1]) < 1:

‎graphs/minimum_spanning_tree_boruvka.py‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,7 @@ def union(self, item1, item2):
146146
self.parent[root2] = root1
147147
return root1
148148

149+
@staticmethod
149150
def boruvka_mst(graph):
150151
"""
151152
Implementation of Boruvka's algorithm

‎maths/chudnovsky_algorithm.py‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ def pi(precision: int) -> str:
4444
getcontext().prec = precision
4545
num_iterations = ceil(precision / 14)
4646
constant_term = 426880 * Decimal(10005).sqrt()
47-
multinomial_term = 1
4847
exponential_term = 1
4948
linear_term = 13591409
5049
partial_sum = Decimal(linear_term)

‎other/triplet_sum.py‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,7 @@ def triplet_sum2(arr: List[int], target: int) -> Tuple[int, int, int]:
6161
left += 1
6262
elif arr[i] + arr[left] + arr[right] > target:
6363
right -= 1
64-
else:
65-
return (0, 0, 0)
64+
return (0, 0, 0)
6665

6766

6867
def solution_times() -> Tuple[float, float]:

‎scheduling/shortest_job_first.py‎

Lines changed: 4 additions & 2 deletions

0 commit comments

Comments
 (0)