{

if (!_settings->isEnabled("warning"))

return;

for (const Token* tok = _tokenizer->list.front(); tok; tok = tok->next()) {

if (!Token::simpleMatch(tok, "assert ("))

continue;

const Token *endTok = tok->next()->link();

for (const Token* tmp = tok->next(); tmp != endTok; tmp = tmp->next()) {

checkVariableAssignment(tmp);

if (tmp->tokType() == Token::eFunction) {

const Function* f = tmp->function();

if (f->nestedIn->isClassOrStruct() && !f->isStatic() && !f->isConst())

sideEffectInAssertError(tmp, f->name()); // Non-const member function called

else {

const Scope* scope = f->functionScope;

if (!scope) continue;

for (const Token *tok2 = scope->classStart; tok2 != scope->classEnd; tok2 = tok2->next()) {

if (tok2->tokType() != Token::eAssignmentOp && tok2->tokType() != Token::eIncDecOp)

continue;

const Variable* var = tok2->previous()->variable();

if (!var || var->isLocal() || (var->isArgument() && !var->isReference() && !var->isPointer()))

continue; // See ticket #4937. Assigning function arguments not passed by reference is ok.

if (var->isArgument() && var->isPointer() && tok2->strAt(-2) != "*")

continue; // Pointers need to be dereferenced, otherwise there is no error

bool noReturnInScope = true;

for (const Token *rt = scope->classStart; rt != scope->classEnd; rt = rt->next()) {

if (rt->str() != "return") continue; // find all return statements

if (inSameScope(rt, tok2)) {

noReturnInScope = false;

break;

}

}

if (noReturnInScope) continue;

sideEffectInAssertError(tmp, f->name());

break;

}

}

}

}

tok = endTok;

}

{

reportError(tok, Severity::warning,

"assertWithSideEffect", "Assert statement calls a function which may have desired side effects: '" + functionName + "'.\n"

"Non-pure function: '" + functionName + "' is called inside assert statement. "

"Assert statements are removed from release builds so the code inside "

"assert statement is not executed. If the code is needed also in release "

"builds, this is a bug.");

{

reportError(tok, Severity::warning,

"assignmentInAssert", "Assert statement modifies '" + varname + "'.\n"

"Variable '" + varname + "' is modified insert assert statement. "

"Assert statements are removed from release builds so the code inside "

"assert statement is not executed. If the code is needed also in release "

"builds, this is a bug.");

{

const Variable* prevVar = assignTok->previous()->variable();

if (!prevVar)

return;

// assignment

if (assignTok->isAssignmentOp() || assignTok->tokType() == Token::eIncDecOp) {

if (prevVar->isConst())

return;

assignmentInAssertError(assignTok, prevVar->name());

}

// TODO: function calls on prevVar

{

// TODO: even if a return is in the same scope, the assignment might not affect it.

return returnTok->scope() == assignTok->scope();