{{ message }}
connecting to Bigtable emulator using environment variable#6067
Merged
Conversation
Now user can connect to Bigtable emulator in three ways: - By settings hostName:portNum in BIGTABLE_EMULATOR_HOST environment variable. - By providing only port number within the local workstation. - By providing hostName & port Number.
googlebot
added
the
cla: yes
rahulKQL
commented
Aug 12, 2019
igorbernstein2
left a comment
igorbernstein2
left a comment
Contributor
There was a problem hiding this comment.
A couple more things:
- please add a log statement notifying the user that the client is targeting the emulator.
- in the test rule please add a precondition preventing tests from running when the environment variable is set. The test environment should be controlled via maven profiles not environment variables and the mixture will just create confusion
- Please add a safe guard to the instance admin client that prevents its use when the env var is set (the emulator doesn't support instance admin api)
Thanks!
igorbernstein2
left a comment
igorbernstein2
left a comment
Contributor
There was a problem hiding this comment.
This is looking good.
| try { | ||
| port = Integer.parseInt(hostAndPort.substring(hostAndPort.lastIndexOf(":") + 1)); | ||
| return newBuilderForEmulator(hostAndPort.substring(0, hostAndPort.lastIndexOf(":")), port); | ||
| } catch (NumberFormatException ex) { |
Contributor
There was a problem hiding this comment.
Please handle IndexOutOfBoundsException as well
| builder | ||
| .stubSettings() | ||
| .setProjectId("fake-project") | ||
| .setInstanceId("fake-instance") |
Contributor
There was a problem hiding this comment.
This diverges from the other clients. I don't think we should set project & instance ids any more
Contributor
There was a problem hiding this comment.
I don't think we should be setting the project instance ids to stay consistent with other languages
Contributor
Author
There was a problem hiding this comment.
For Java, we have projectId & instanceId required. Shall I remove the Preconditions checks for projectId & InstanceId?
I would vote to keep these checks and continue with "fake-project" & "fake-instance".
Contributor
There was a problem hiding this comment.
I'm not sure what you mean by that. I'm picturing something along the lines of:
BigtableTableAdminSettings.newBuilderForEmulator("localhost", 1234).setProjectId("blah").setInstanceId("blah2").build()
I think the other client languages require something similar
Contributor
Author
There was a problem hiding this comment.
Thanks for the explanation, I mistook it as emulator without any projectId & instanceId. Have updated with the suggestion. please have a look.
- Updated null check with String.isNullOrEmpty - Handled IndexOutOfBoundsException - fixed java doc in newBuilder() - Adapted with TruthJunit.assume() instead of Assert.assume().
igorbernstein2
approved these changes
Aug 19, 2019
igorbernstein2
left a comment
igorbernstein2
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks for implementing this!
This was referenced Aug 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6057
User can now connect to Bigtable emulator in three ways:
BIGTABLE_EMULATOR_HOSTenvironment variable.