{{ message }}
spanner-jdbc: Add jdbc statement integration tests#6033
Merged
kolea2 merged 4 commits intoAug 19, 2019
Conversation
googlebot
added
the
cla: yes
kolea2
suggested changes
Aug 7, 2019
| @@ -0,0 +1,30 @@ | |||
| (1,'Marilyn','Lindsey',FROM_BASE64('iVBORw0KGgoAAAANSUhEUgAAAgAAAAIACAIAAAB7GkOtAAANGklEQVR4nOzXi6/X9X3H8R56RO222IsXqqgwGROYWuf9wnDipV7B0GmxYzWr9bKNqDGatraltop2ird1hTXrqvbMiChiylA7mCtQK4aySkstRiyFrLZQy5DCWaMz+yteSZPX4/EHvD4n3/NLnnkPzlg//l1JC68bjO6fc+LXo/sv3XhXdH/M7tXR/S0fGBndf23ei9H9WzYfG91fdtoHo/uzn70pun/YtrOi+zMvzv79x6xeHt1/e8yz0f1fjNoW3X9qbvb7jIiuA/A7SwAASgkAQCkBACglAAClBACglAAAlBIAgFICAFBKAABKCQBAKQEAKCUAAKUEAKCUAACUEgCAUgIAUEoAAEoJAEApAQAoJQAApQQAoJQAAJQSAIBSAgBQSgAASgkAQCkBACglAAClBACglAAAlBo89IZzow8c/uab0f1Hj389uv/YCxuj+19d/Ep0f9GmO6L7P7p/Q3T/H8/5fnT/rzbvju6/svaK6P45i7L/349svSq6v9+Ri6P7ixf9KLr/1BV/G90/deeHo/suAIBSAgBQSgAASgkAQCkBACglAAClBACglAAAlBIAgFICAFBKAABKCQBAKQEAKCUAAKUEAKCUAACUEgCAUgIAUEoAAEoJAEApAQAoJQAApQQAoJQAAJQSAIBSAgBQSgAASgkAQCkBACglAAClBACg1MAXdv44+sAXb18S3R+/eUJ0f++3hqP7p/7LtdH9bWsejO5/dvry6P4Hr50b3Z8/fFp0/4Sxfx/d3/ejg9H9vca9Gt0fumQgur/0kDOj+7fd8rXo/tCMA6L7LgCAUgIAUEoAAEoJAEApAQAoJQAApQQAoJQAAJQSAIBSAgBQSgAASgkAQCkBACglAAClBACglAAAlBIAgFICAFBKAABKCQBAKQEAKCUAAKUEAKCUAACUEgCAUgIAUEoAAEoJAEApAQAoJQAApQQAoNTA8J3viz4wb/jM6P49P/+z6P53Zh8U3b/wgInR/aVbr4vuL1h4VnR/979Pi+6f8A8jo/t//OU3ovuzj748uv/cnuHo/thRv4ru3zr4y+j+GeMWR/c3nj09uu8CACglAAClBACglAAAlBIAgFICAFBKAABKCQBAKQEAKCUAAKUEAKCUAACUEgCAUgIAUEoAAEoJAEApAQAoJQAApQQAoJQAAJQSAIBSAgBQSgAASgkAQCkBACglAAClBACglAAAlBIAgFICAFBKAABKDUwb92r0gSMnvxzdv3HTr6L7w19ZG91f++Svo/tDrx0f3X9mzvnR/Ykj50T3779p/+j+fld/Lrq/7LHXo/u/XXJRdP+PDs3+frbPuiq7//D10f3hUUPRfRcAQCkBACglAAClBACglAAAlBIAgFICAFBKAABKCQBAKQEAKCUAAKUEAKCUAACUEgCAUgIAUEoAAEoJAEApAQAoJQAApQQAoJQAAJQSAIBSAgBQSgAASgkAQCkBACglAAClBACglAAAlBIAgFICAFBq4Mb5y6IPfOzRb0X37xtxcXT/ic+cF92fsG1udP+6vZ+J7u9/+3ej+2cNHhTdX/bC1dH9rZeNju7PWnBudP/e/f8yun/UZ98T3b9s6r3R/XXT/y26/7MfZ7+PCwCglAAAlBIAgFICAFBKAABKCQBAKQEAKCUAAKUEAKCUAACUEgCAUgIAUEoAAEoJAEApAQAoJQAApQQAoJQAAJQSAIBSAgBQSgAASgkAQCkBACglAAClBACglAAAlBIAgFICAFBKAABKCQBAKQEAKDVwyikHRh94acTj0f2jxx4f3f/QHVOi+zdcNia6/9Bh86L76w+/Jrp/0p/Pie7ftm6f6P4++x4b3b977XHR/SOvHR3dX7Thruj+C4+/Ed1ftfTV6P4d962L7rsAAEoJAEApAQAoJQAApQQAoJQAAJQSAIBSAgBQSgAASgkAQCkBACglAAClBACglAAAlBIAgFICAFBKAABKCQBAKQEAKCUAAKUEAKCUAACUEgCAUgIAUEoAAEoJAEApAQAoJQAApQQAoJQAAJQSAIBSgx/65rnRB6ZufX90/80Fo6P739t+W3T/lx9fE93f8r1jo/vXzLg0uv/l3x4Q3V85+/ei+1ePXh3d/+uT/iS6P/jt46L766bMie6PfuCJ6P7ctWOi+5PXHBbddwEAlBIAgFICAFBKAABKCQBAKQEAKCUAAKUEAKCUAACUEgCAUgIAUEoAAEoJAEApAQAoJQAApQQAoJQAAJQSAIBSAgBQSgAASgkAQCkBACglAAClBACglAAAlBIAgFICAFBKAABKCQBAKQEAKCUAAKUGp37jzOgDF957V3T/5JP/Nbr/yFFD0f3fv/y86P75v1kd3Z+/18jo/uOPZH+fIzZE5991+pVfiO6fd8Z90f1XDrwjuv8/L78e3X962uLo/srJ46P7q3feE913AQCUEgCAUgIAUEoAAEoJAEApAQAoJQAApQQAoJQAAJQSAIBSAgBQSgAASgkAQCkBACglAAClBACglAAAlBIAgFICAFBKAABKCQBAKQEAKCUAAKUEAKCUAACUEgCAUgIAUEoAAEoJAEApAQAoJQAApQY+v/a16APTnvxJdP+4H8yP7p+4ZEp0f9JvtkT35x9+TXR/yxNfiu7PPGhPdP8Dc3ZF9zePfya6P+v590T3d2zYHd1/aN7l0f0Jkz4Z3Z9087js/qQro/suAIBSAgBQSgAASgkAQCkBACglAAClBACglAAAlBIAgFICAFBKAABKCQBAKQEAKCUAAKUEAKCUAACUEgCAUgIAUEoAAEoJAEApAQAoJQAApQQAoJQAAJQSAIBSAgBQSgAASgkAQCkBACglAAClBACg1MCZtxwYfeCIz30lur9z+6To/n7LL4zuXzb9v6P7cy96Obp/64ObovsT9ro0ur98zlHR/ROWXRTdv+FvTozuTz5iQnR/1ANvRfd3feuH0f2ZH/l0dH/p2b+I7rsAAEoJAEApAQAoJQAApQQAoJQAAJQSAIBSAgBQSgAASgkAQCkBACglAAClBACglAAAlBIAgFICAFBKAABKCQBAKQEAKCUAAKUEAKCUAACUEgCAUgIAUEoAAEoJAEApAQAoJQAApQQAoJQAAJQSAIBSA7PWfCb6wPS9/yO6//CKidH9BfecFN1/+uQbovtrhsZF9/c8vSa6/9Njst//9sHnovubJu4f3X/2L74R3T9l5Fej+7dtG4ruf/uT+0T37/7E9dH9R99/QXTfBQBQSgAASgkAQCkBACglAAClBACglAAAlBIAgFICAFBKAABKCQBAKQEAKCUAAKUEAKCUAACUEgCAUgIAUEoAAEoJAEApAQAoJQAApQQAoJQAAJQSAIBSAgBQSgAASgkAQCkBACglAAClBACglAAAlBrc96XvRx/YfuhN0f0nr7w+ur/1D34W3X/3zx+I7h885cXo/p3XDET3T/3UMdH9+9ZOje5fvOXy6P7dt384uj/tBwdG92fNeDu6v2veG9H9M762Iro/4bjHovsuAIBSAgBQSgAASgkAQCkBACglAAClBACglAAAlBIAgFICAFBKAABKCQBAKQEAKCUAAKUEAKCUAACUEgCAUgIAUEoAAEoJAEApAQAoJQAApQQAoJQAAJQSAIBSAgBQSgAASgkAQCkBACglAAClBACg1MCIhf8XfeAP/2s4uv/crr+L7k895J7o/oxDbo7uf3fm0uj+uaN+Et1fMfDD6P4FU7J//8b1b0f3D/3mQ9H90RecHt0f89G9o/vPf2lJdP/ji3dG9289OLvvAgAoJQAApQQAoJQAAJQSAIBSAgBQSgAASgkAQCkBACglAAClBACglAAAlBIAgFICAFBKAABKCQBAKQEAKCUAAKUEAKCUAACUEgCAUgIAUEoAAEoJAEApAQAoJQAApQQAoJQAAJQSAIBSAgBQSgAASg186qzx0Qfe2bFfdP/B9306uv/5954T3f/iTx+O7l/yyKXR/YETn4ruH/1Pc6P7/3zyFdH9Px15RHR/8XuPje4PrZwd3T/t7KXR/f+dvCq6f9VbL0b33z3+19F9FwBAKQEAKCUAAKUEAKCUAACUEgCAUgIAUEoAAEoJAEApAQAoJQAApQQAoJQAAJQSAIBSAgBQSgAASgkAQCkBACglAAClBACglAAAlBIAgFICAFBKAABKCQBAKQEAKCUAAKUEAKCUAACUEgCAUgIAUGpw4iUfiz6wYtXY6P7s7zwf3d9xxZLo/titM6P7mz+R3Z8246Lo/jur1kf3D56+Mrp//u7d0f2Fd94f3b//6zui+xsn3xzdv3bH6dH9cXuOiO7f+p8jo/suAIBSAgBQSgAASgkAQCkBACglAAClBACglAAAlBIAgFICAFBKAABKCQBAKQEAKCUAAKUEAKCUAACUEgCAUgIAUEoAAEoJAEApAQAoJQAApQQAoJQAAJQSAIBSAgBQSgAASgkAQCkBACglAAClBACg1P8HAAD//+SLeeht2MttAAAAAElFTkSuQmCC'),DATE '1906-04-28'); | |||
Contributor
There was a problem hiding this comment.
As discussed, let's switch the BASE64 values to something generated by RandomResultSetGenerator.
Contributor
Author
There was a problem hiding this comment.
The BASE64 values have been replaced with generated random numbers.
olavloite
force-pushed
the
spanner-jdbc-cleanup-it-jdbc-statements
branch
from
01814a6 to
f189dfd
Compare
Contributor
Author
|
Test failure is caused by flake that is addressed by #6095. |
kolea2
previously approved these changes
Aug 16, 2019
Contributor
|
LGTM after rebase |
olavloite
force-pushed
the
spanner-jdbc-cleanup-it-jdbc-statements
branch
from
59d2da3 to
4829aaf
Compare
Contributor
Author
kolea2
approved these changes
Aug 19, 2019
This was referenced Aug 22, 2019
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Mar 23, 2026
* add jdbc statement integration tests * fix parsing error * replace base64 with random numbers * use generated names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds integration tests for JDBC statements and prepared statements.