Spanner: Properly end span for ResumableStreamIterator. by kolea2 · Pull Request #5309 · googleapis/google-cloud-java · GitHub
Skip to content

Spanner: Properly end span for ResumableStreamIterator.#5309

Merged
kolea2 merged 2 commits into
googleapis:masterfrom
kolea2:span-fix
Jun 4, 2019
Merged

Spanner: Properly end span for ResumableStreamIterator.#5309
kolea2 merged 2 commits into
googleapis:masterfrom
kolea2:span-fix

Conversation

@kolea2

@kolea2 kolea2 commented Jun 4, 2019

Copy link
Copy Markdown
Contributor

Most changes in the test are because of variable renaming, new test is closedSpan().

@kolea2 kolea2 requested a review from a team June 4, 2019 16:35
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 4, 2019
@kolea2 kolea2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 4, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 4, 2019
@codecov

codecov Bot commented Jun 4, 2019

Copy link
Copy Markdown

@kolea2 kolea2 merged commit b24520a into googleapis:master Jun 4, 2019
@kolea2 kolea2 deleted the span-fix branch June 4, 2019 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants