{{ message }}
Allow colons in Identity values#5029
Merged
Merged
Conversation
googlebot
added
the
cla: yes
chingor13
requested changes
Apr 26, 2019
chingor13
left a comment
chingor13
left a comment
Contributor
There was a problem hiding this comment.
Should we still throw an IllegalArgumentException if there's more parts than we expect?
chingor13
reviewed
Apr 29, 2019
…-java into allowcolons
JesseLovelace
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
JesseLovelace
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
chingor13
approved these changes
May 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to address internal bug 118884564. Identity is written for colons not to be allowed in the value, however colons are actually allowed in some legacy cases, like domain-scoped project IDs.