Comparing chromiumembedded:master...GEBIT:customized · chromiumembedded/java-cef · GitHub
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: chromiumembedded/java-cef
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: GEBIT/java-cef
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: customized
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 14 commits
  • 16 files changed
  • 1 contributor

Commits on Jan 2, 2020

  1. added framework_dir_path to settings 

    This allows to set the framework dir path which is important for MacOS
    @S1artie
    S1artie committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    beafb86 View commit details
    Browse the repository at this point in the history

  2. added reenter protection to onGotFocus handler 

    It appears to be possible to get a loop of focus handlers calling themselves over and over again (if I remember correctly this was only observable on Windows). In order to stop this loop, a thread-local reentry protection was added.
    @S1artie
    S1artie committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    0426552 View commit details
    Browse the repository at this point in the history

  3. Remove loading of native libraries from CefApp 

    When packaging CEF within OSGi bundles for auto-extraction, it is necessary to orchestrate loading of the native libs myself instead of having CefApp load them. Therefore I disabled the convenient auto-loading code.
    @S1artie
    S1artie committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    75de40f View commit details
    Browse the repository at this point in the history

  4. fixed NPEs in offscreen rendering after browser component removal 

    When a browser window was removed from the GUI, NPEs could be thrown while it was removed and when it was re-added for further display. The removal and re-adding itself seemed to work fine, but the NPEs were distracting. This was observed primarily on Linux.
    @S1artie
    S1artie committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    49ed293 View commit details
    Browse the repository at this point in the history

  5. Added helper rpath modification to build process (MacOS)

    @S1artie
    S1artie committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    a034c71 View commit details
    Browse the repository at this point in the history

  6. statically link libstdc++ & libgcc on Linux 

    This allows us to use the compiled binaries more universally among Linux distributions
    @S1artie
    S1artie committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    2e2ff76 View commit details
    Browse the repository at this point in the history

  7. added src jar to ant build

    @S1artie
    S1artie committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    c5fafb2 View commit details
    Browse the repository at this point in the history

  8. added screenshotting functionality to offscreen renderer

    @S1artie
    S1artie committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    ba02c14 View commit details
    Browse the repository at this point in the history

  9. speedup of message pump from 30hz to 60hz 

    This leads to smoother animations and processing of GUI stuff in offscreen scenarios as well as in the on-screen rendering scenario on MacOS
    @S1artie
    S1artie committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    b2c1052 View commit details
    Browse the repository at this point in the history

  10. Add support for providing a Framework Path on CefApp.startup() 

    This is necessary because of https://bitbucket.org/chromiumembedded/cef/issues/2459/macos-enable-the-macv2sandbox and is complemented by some modifications in CEF as well.
    @S1artie
    S1artie committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    71613e3 View commit details
    Browse the repository at this point in the history

  11. Allow to disable the Chromium rendering pipeline 

    This commit works only in conjunction with an identically-named CEF commit and introduces a hook to Chromium which allow the embedding application to disable and enable the rendering pipeline of an embedded browser window at will. To be more exact: the pipeline is actually cut short the moment that rendered stuff would be drawn to the screen otherwise, so effectively, everything just works as it normally would (event handlers being called and such), but the screen doesn't update anymore until rendering is re-enabled.
    @S1artie
    S1artie committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    9e4e69c View commit details
    Browse the repository at this point in the history

  12. fixed Java 11 AWT component peer problem 

    This solution to a Java 11 specific problem on MacOS (compile and runtime) was taken from the following java-cef support forum post: https://magpcss.org/ceforum/viewtopic.php?p=40962#p40962
    @S1artie
    S1artie committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    9839fe1 View commit details
    Browse the repository at this point in the history

  13. removed junit test classes from compilation 

    for some unknown reason these don't compile correctly - but we aren't particularly interested in them anyway, so...
    @S1artie
    S1artie committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    5a869b6 View commit details
    Browse the repository at this point in the history

  14. Added possibility for HiDPI scaling correction 

    This is necessary in offscreen rendering situations if the result of the offscreen-rendered browser is to be displayed on a HiDPI display (with a non-1:1 mapping between physical and logical pixels). In such situations, JCEF would render things at the wrong scaling. With HiDPI scaling correction, one can fix the scaling (although the application is responsible for supplying a browser with the necessary info about the scaling factor).
In addition, while HiDPI works out of the box in windowed rendering mode on MacOS, it does not do so on Windows, hence this patch also enables HiDPI scaling on Windows in windowed and offscreen mode. There's the caveat however that in order to even use HiDPI on Windows, a Java 9+ runtime is needed (the Java 8 Windows runtime does not correctly support it).
This patch covers and was tested with MacOS and Windows. Linux should theoretically work much like Windows (if it doesn't even work out of the box), but as HiDPI support on Linux is pretty spotty still, it was not tested at all.
    @S1artie
    S1artie committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    6cf97d2 View commit details
    Browse the repository at this point in the history
Loading