fix(ci): rebuild PCH when an input header is touched, not only when i… · FastLED/FastLED@55909ef · GitHub
Skip to content

Commit 55909ef

Browse files
authored
fix(ci): rebuild PCH when an input header is touched, not only when its content changes (#4839)
clang 21 (-fpch-validate-input-files-content) accepts a PCH whose inputs are byte-identical but have a newer mtime, then fails to tie those headers to the PCH copies, so #pragma once stops deduping them and every consumer TU dies with 'redefinition of ...'. compile_pch.py skipped the rebuild on a content-hash match, which is exactly that case. Rebuild whenever any input is newer than the PCH, in both the skip path and invalidate_stale_pch.
1 parent abf9463 commit 55909ef

2 files changed

Lines changed: 63 additions & 2 deletions

File tree

‎ci/compile_pch.py‎

Lines changed: 32 additions & 1 deletion

‎ci/tests/test_pch_staleness_guards.py‎

Lines changed: 31 additions & 1 deletion

0 commit comments

Comments
 (0)