Merge pull request docker-java#1155 from KostyaSha/pull/521

KostyaSha · web-flow · commit a3623cd99d53 · 2019-01-29T01:30:41.000+03:00
Pull/521
diff --git a/src/main/java/com/github/dockerjava/core/exec/SaveImageCmdExec.java b/src/main/java/com/github/dockerjava/core/exec/SaveImageCmdExec.java
@@ -1,14 +1,14 @@
 package com.github.dockerjava.core.exec;
 
-import java.io.InputStream;
-
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
 import com.github.dockerjava.api.command.SaveImageCmd;
 import com.github.dockerjava.core.DockerClientConfig;
 import com.github.dockerjava.core.MediaType;
 import com.github.dockerjava.core.WebTarget;
+import com.google.common.base.Strings;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.InputStream;
 
 public class SaveImageCmdExec extends AbstrSyncDockerCmdExec<SaveImageCmd, InputStream> implements SaveImageCmd.Exec {
     private static final Logger LOGGER = LoggerFactory.getLogger(SaveImageCmdExec.class);
@@ -19,8 +19,14 @@ public SaveImageCmdExec(WebTarget baseResource, DockerClientConfig dockerClientC
 
     @Override
     protected InputStream execute(SaveImageCmd command) {
-        WebTarget webResource = getBaseResource().path("/images/" + command.getName() + "/get").queryParam("tag",
-                command.getTag());
+
+        String name = command.getName();
+        if (!Strings.isNullOrEmpty(command.getTag())) {
+            name += ":" + command.getTag();
+        }
+
+        WebTarget webResource = getBaseResource().
+                path("/images/" + name + "/get");
 
         LOGGER.trace("GET: {}", webResource);
         return webResource.request().accept(MediaType.APPLICATION_JSON).get();
diff --git a/src/main/java/com/github/dockerjava/jaxrs/SaveImageCmdExec.java b/src/main/java/com/github/dockerjava/jaxrs/SaveImageCmdExec.java
@@ -12,6 +12,7 @@
 import com.github.dockerjava.api.command.SaveImageCmd;
 import com.github.dockerjava.core.DockerClientConfig;
 import com.github.dockerjava.jaxrs.util.WrappedResponseInputStream;
+import com.google.common.base.Strings;
 
 public class SaveImageCmdExec extends AbstrSyncDockerCmdExec<SaveImageCmd, InputStream> implements SaveImageCmd.Exec {
     private static final Logger LOGGER = LoggerFactory.getLogger(SaveImageCmdExec.class);
@@ -22,8 +23,13 @@ public SaveImageCmdExec(WebTarget baseResource, DockerClientConfig dockerClientC
 
     @Override
     protected InputStream execute(SaveImageCmd command) {
-        WebTarget webResource = getBaseResource().path("/images/" + command.getName() + "/get").queryParam("tag",
-                command.getTag());
+        // If tag is present, only tar the specific image
+        // else tar all the images with the same name
+        String name = command.getName();
+        if (!Strings.isNullOrEmpty(command.getTag())) {
+            name += ":" + command.getTag();
+        }
+        WebTarget webResource = getBaseResource().path("/images/" + name + "/get");
 
         LOGGER.trace("GET: {}", webResource);
         Response response = webResource.request().accept(MediaType.APPLICATION_JSON).get();
diff --git a/src/test/java/com/github/dockerjava/cmd/SaveImageCmdIT.java b/src/test/java/com/github/dockerjava/cmd/SaveImageCmdIT.java
@@ -19,6 +19,10 @@ public void saveImage() throws Exception {
         InputStream image = IOUtils.toBufferedInputStream(dockerRule.getClient().saveImageCmd("busybox").exec());
         assertThat(image.available(), greaterThan(0));
 
+        InputStream image2 = IOUtils.toBufferedInputStream(dockerRule.getClient().saveImageCmd("busybox").withTag("latest").exec());
+        assertThat(image2.available(), greaterThan(0));
+
+
     }
 
 }

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,10 @@ public void saveImage() throws Exception {`
`19`	`19`	`InputStream image = IOUtils.toBufferedInputStream(dockerRule.getClient().saveImageCmd("busybox").exec());`
`20`	`20`	`assertThat(image.available(), greaterThan(0));`
`21`	`21`
	`22`	`+ InputStream image2 = IOUtils.toBufferedInputStream(dockerRule.getClient().saveImageCmd("busybox").withTag("latest").exec());`
	`23`	`+ assertThat(image2.available(), greaterThan(0));`
	`24`	`+`
	`25`	`+`
`22`	`26`	`}`
`23`	`27`
`24`	`28`	`}`