dunkmann00 added 2 commits

April 7, 2023 16:11


          Allow specifying 'all' for process restarts

9df8b8f


          Update README for auto restart all

249f8b5

dunkmann00 changed the title ~~Allow specifying 'all' for process restarts~~ Allow specifying 'all' for process auto restarts

Apr 8, 2023

dunkmann00 commented Apr 19, 2023

Contributor Author

Hey @DarthSim! If you have a chance could you look this over? Thanks!

catpreneur commented Aug 5, 2023 •

edited

Loading

@dunkmann00 Thanks for this pr!

Look at line 96

overmind/start/command.go

Line 96 in 7d97057

(h.AnyCanDie || utils.StringsContain(canDie, e.OrigName)),

They use a boolean to indicate all can die, not all string. Maybe you should make it a boolean so it's consistent.

dunkmann00 commented Aug 5, 2023 •

edited

Loading

Contributor Author

Thanks @oofdog! Like I said in my initial comment of this PR, after seeing the suggestion in #153, I thought using all made more sense.

Just to add some more detail -
There is precedent for this in Overmind. Setting the number of instances of a process (formation) uses all as well.

From the Readme:

There is a special name all that you can use to scale all processes at once:

$ overmind start -m all=2,worker=5
$ OVERMIND_FORMATION=all=2,worker=5 overmind start

IMHO, I think changing can-die to support all (or any if preferable) would be better for consistency and simplicity.

P.S. Here is where formation is handled in the code:

overmind/start/procfile.go

Lines 43 to 48 in 7d97057

    
           num := 1 
        
           if fnum, ok := formation[name]; ok { 
        
           	num = fnum 
        
           } else if fnum, ok := formation["all"]; ok { 
        
           	num = fnum 
        
           }

dunkmann00 commented Sep 12, 2023

Contributor Author

Hey @DarthSim! Just wanted to reach out again and see if this PR looks good to you. Thanks!

Envek approved these changes

Sep 13, 2023

View reviewed changes

Envek left a comment

Collaborator

It is elegant! @mrexox, wdyt?

mrexox approved these changes

Sep 14, 2023

View reviewed changes

mrexox left a comment

Collaborator

@Envek , agree!

Envek merged commit 7f78ffd into DarthSim:master

Sep 15, 2023

dunkmann00 commented Sep 15, 2023

Contributor Author

Thanks!

dunkmann00 deleted the restart-all branch

September 15, 2023 13:07

chenrui333 mentioned this pull request

Mar 25, 2024

overmind 2.5.0 Homebrew/homebrew-core#167160

Merged

Sunbelt Computer Software

PL/B Language Development and Support