[fix] impala varchar data error; storeType Null point Exception; valu… · DTStack/flinkStreamSQL@d8873f9 · GitHub
Skip to content

Commit d8873f9

Browse files
committed
[fix] impala varchar data error; storeType Null point Exception; values condition quote bug;
1 parent 59e83f8 commit d8873f9

4 files changed

Lines changed: 38 additions & 9 deletions

File tree

‎impala/impala-sink/src/main/java/com/dtstack/flink/sql/sink/impala/ImpalaOutputFormat.java‎

Lines changed: 8 additions & 6 deletions

‎impala/impala-sink/src/main/java/com/dtstack/flink/sql/sink/impala/ImpalaSink.java‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@
4646
public class ImpalaSink implements RetractStreamTableSink<Row>, IStreamSinkGener<ImpalaSink> {
4747

4848
private static final String DEFAULT_STORE_TYPE = "kudu";
49-
private static final String DEFAULT_PARTITION_MODE = "dynamic";
5049

5150
protected String[] fieldNames;
5251
TypeInformation<?>[] fieldTypes;

‎impala/impala-sink/src/main/java/com/dtstack/flink/sql/sink/impala/table/ImpalaSinkParser.java‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
import java.util.Arrays;
2626
import java.util.List;
2727
import java.util.Map;
28+
import java.util.Objects;
2829

2930
/**
3031
* Date: 2020/10/14
@@ -76,6 +77,8 @@ public class ImpalaSinkParser extends AbstractTableParser {
7677

7778
private static final String KUDU_TYPE = "kudu";
7879

80+
private static final String DEFAULT_STORE_TYPE = "kudu";
81+
7982
private static final String STORE_TYPE_KEY = "storeType";
8083

8184
private static final String KRB_DEFAULT_REALM = "HADOOP.COM";
@@ -123,13 +126,13 @@ public AbstractTableInfo getTableInfo(String tableName, String fieldsInfo, Map<S
123126
}
124127

125128
String storeType = MathUtil.getString(props.get(STORE_TYPE_KEY.toLowerCase()));
126-
impalaTableInfo.setStoreType(storeType);
129+
impalaTableInfo.setStoreType(Objects.isNull(storeType) ? DEFAULT_STORE_TYPE : storeType);
127130

128131
String enablePartitionStr = (String) props.get(ENABLE_PARTITION_KEY.toLowerCase());
129132
boolean enablePartition = MathUtil.getBoolean(enablePartitionStr == null ? "false" : enablePartitionStr);
130133
impalaTableInfo.setEnablePartition(enablePartition);
131134

132-
if (!storeType.equalsIgnoreCase(KUDU_TYPE) && enablePartition) {
135+
if (!impalaTableInfo.getStoreType().equalsIgnoreCase(KUDU_TYPE) && enablePartition) {
133136
String partitionFields = MathUtil.getString(props.get(PARTITION_FIELDS_KEY.toLowerCase()));
134137
impalaTableInfo.setPartitionFields(partitionFields);
135138
}

‎localTest/pom.xml‎

Lines changed: 25 additions & 0 deletions

0 commit comments

Comments
 (0)