FilesExpand file tree

master

/

DiffClassRegistrationTest.php

Copy path

Blame

More file actions

Blame

More file actions

Latest commit

 

History

History

History

114 lines (99 loc) · 3.69 KB

master

/

DiffClassRegistrationTest.php

Copy path

Top

File metadata and controls

• Code
• Blame

114 lines (99 loc) · 3.69 KB

Raw

Copy raw file

Download raw file

Open symbols panel

Edit and raw actions

1

2

3

4

5

6

7

8

9

10

11

12

13

14

15

16

17

18

19

20

21

22

23

24

25

26

27

28

29

30

31

32

33

34

35

36

37

38

39

40

41

42

43

44

45

46

47

48

49

50

51

52

53

54

55

56

57

58

59

60

61

62

63

64

65

66

67

68

69

70

71

72

73

74

75

76

77

78

79

80

81

82

83

84

85

86

87

88

89

90

91

92

93

94

95

96

97

98

99

100

101

102

103

104

105

106

107

108

109

110

111

112

113

114

<?php

namespace DBDiff\Tests\Unit;

use PHPUnit\Framework\TestCase;

use DBDiff\SQLGen\DiffSorter;

/**

* Structural invariants every diff kind has to satisfy.

*

* Both are things a new diff kind gets wrong silently rather than loudly:

*

* DiffSorter looks its priority up with $orderMap[$shortName] and no fallback,

* so a kind missing from either order list raises "Undefined array key" the

* first time a diff happens to contain it — which may be long after the code

* was added, and only for the schemas that trigger it.

*

* MigrationGenerator resolves the SQL writer by name, appending "SQL" to the

* diff's short name, so a missing counterpart is a "class not found" at

* generation time rather than anything a type checker would catch.

*

* Asserted by walking src/Diff rather than a hand-kept list, so a kind added

* without either piece fails here instead of in the field.

*/

class DiffClassRegistrationTest extends TestCase

{

/** @return string[] */

private function diffClassNames(): array

{

$names = [];

foreach (glob(__DIR__ . '/../../src/Diff/*.php') as $file) {

$names[] = basename($file, '.php');

}

sort($names);

return $names;

}

private function order(string $property): array

{

$reflected = new \ReflectionProperty(DiffSorter::class, $property);

$reflected->setAccessible(true);

return $reflected->getValue(new DiffSorter());

}

public function testSubSlotsBelongToRealDiffClassesAndAppearInBothOrders(): void

{

foreach (DiffSorter::SUB_SLOTS as $slot => $class) {

$this->assertContains($class, $this->diffClassNames());

$this->assertContains($slot, $this->order('up_order'));

$this->assertContains($slot, $this->order('down_order'));

}

}

public function testThereAreDiffClassesToCheck(): void

{

// Guards the assertions below against a glob that silently finds none.

$this->assertGreaterThan(20, count($this->diffClassNames()));

}

public function testEveryDiffClassHasAnUpOrderPriority(): void

{

$missing = array_diff($this->diffClassNames(), $this->order('up_order'));

$this->assertSame(

[],

array_values($missing),

'diff kinds missing from DiffSorter::$up_order: ' . implode(', ', $missing)

);

}

public function testEveryDiffClassHasADownOrderPriority(): void

{

$missing = array_diff($this->diffClassNames(), $this->order('down_order'));

$this->assertSame(

[],

array_values($missing),

'diff kinds missing from DiffSorter::$down_order: ' . implode(', ', $missing)

);

}

public function testEveryDiffClassHasASqlCounterpart(): void

{

$missing = [];

foreach ($this->diffClassNames() as $name) {

$path = __DIR__ . '/../../src/SQLGen/DiffToSQL/' . $name . 'SQL.php';

if (!is_file($path)) {

$missing[] = $name;

}

}

$this->assertSame(

[],

$missing,

'diff kinds with no DiffToSQL counterpart: ' . implode(', ', $missing)

);

}

public function testOrderListsNameOnlyRealDiffClasses(): void

{

$known = array_merge($this->diffClassNames(), array_keys(DiffSorter::SUB_SLOTS));

foreach (['up_order', 'down_order'] as $property) {

$unknown = array_diff($this->order($property), $known);

$this->assertSame(

[],

array_values($unknown),

"DiffSorter::\$$property names classes that do not exist: "

. implode(', ', $unknown)

);

}

}

}