Declare nullable parameter types explicitly (#6775) · Codeception/Codeception@eb0634c · GitHub
Skip to content

Commit eb0634c

Browse files
authored
Declare nullable parameter types explicitly (#6775)
Implicit nullable types are deprecated in PHP 8.4
1 parent 8d4f11d commit eb0634c

31 files changed

Lines changed: 44 additions & 43 deletions

‎.php-cs-fixer.dist.php‎

Lines changed: 1 addition & 0 deletions

‎src/Codeception/Application.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ protected function getCustomCommandName(string $commandClass): string
9999
*
100100
* @inheritDoc
101101
*/
102-
public function run(InputInterface $input = null, OutputInterface $output = null): int
102+
public function run(?InputInterface $input = null, ?OutputInterface $output = null): int
103103
{
104104
if (!$input instanceof InputInterface) {
105105
$input = $this->getCoreArguments();

‎src/Codeception/Codecept.php‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ private function registerReporters(): void
192192
}
193193
}
194194

195-
public function run(string $suite, string $test = null, array $config = null): void
195+
public function run(string $suite, ?string $test = null, ?array $config = null): void
196196
{
197197
ini_set(
198198
'memory_limit',
@@ -241,7 +241,7 @@ public function run(string $suite, string $test = null, array $config = null): v
241241
}
242242
}
243243

244-
public function runSuite(array $settings, string $suite, string $test = null): void
244+
public function runSuite(array $settings, string $suite, ?string $test = null): void
245245
{
246246
$settings['shard'] = $this->options['shard'];
247247
$suiteManager = new SuiteManager($this->dispatcher, $suite, $settings, $this->options);

‎src/Codeception/Command/Shared/ConfigTrait.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ protected function getSuiteConfig(string $suite): array
2626
return Configuration::suiteSettings($suite, $this->getGlobalConfig());
2727
}
2828

29-
protected function getGlobalConfig(string $conf = null): array
29+
protected function getGlobalConfig(?string $conf = null): array
3030
{
3131
return Configuration::config($conf);
3232
}

‎src/Codeception/Configuration.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ class Configuration
148148
* @return array<string, mixed>
149149
* @throws ConfigurationException
150150
*/
151-
public static function config(string $configFile = null): array
151+
public static function config(?string $configFile = null): array
152152
{
153153
if (!$configFile && self::$config) {
154154
return self::$config;

‎src/Codeception/Exception/Error.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
class Error extends Exception
1010
{
11-
public function __construct(string $message, int $code, string $file, int $line, \Exception $previous = null)
11+
public function __construct(string $message, int $code, string $file, int $line, ?\Exception $previous = null)
1212
{
1313
parent::__construct($message, $code, $previous);
1414

‎src/Codeception/Exception/ExtensionException.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ class ExtensionException extends Exception
1515
*
1616
* @param object|string $extension
1717
*/
18-
public function __construct($extension, string $message, Exception $previous = null)
18+
public function __construct($extension, string $message, ?Exception $previous = null)
1919
{
2020
parent::__construct($message, 0, $previous);
2121
if (is_object($extension)) {

‎src/Codeception/Exception/ModuleConfigException.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ class ModuleConfigException extends Exception
1717
*
1818
* @param object|string $module
1919
*/
20-
public function __construct($module, string $message, Exception $previous = null)
20+
public function __construct($module, string $message, ?Exception $previous = null)
2121
{
2222
if (is_object($module)) {
2323
$module = $module::class;

‎src/Codeception/Exception/TestParseException.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
class TestParseException extends Exception
1010
{
11-
public function __construct(string $fileName, string $errors = null, int $line = null)
11+
public function __construct(string $fileName, ?string $errors = null, ?int $line = null)
1212
{
1313
$this->message = "Couldn't parse test '{$fileName}'";
1414
if ($line !== null) {

‎src/Codeception/InitTemplate.php‎

Lines changed: 1 addition & 1 deletion

0 commit comments

Comments
 (0)