Merged PR 141832: Bug fix: use post request instead put in update filters for visual API

neryaco · neryaco · commit f066ce82b97d · 2021-01-26T11:29:17.000Z
diff --git a/dist/powerbi-client.d.ts b/dist/powerbi-client.d.ts
@@ -1,4 +1,4 @@
-/*! powerbi-client v2.17.1 | (c) 2016 Microsoft Corporation MIT */
+/*! powerbi-client v2.17.2 | (c) 2016 Microsoft Corporation MIT */
 declare module "util" {
     import { HttpPostMessage } from 'http-post-message';
     /**
@@ -1133,8 +1133,11 @@ declare module "report" {
          *
          * ```javascript
          * const newSettings = {
-         *   navContentPaneEnabled: true,
-         *   filterPaneEnabled: false
+         *   panes: {
+         *     filters: {
+         *       visible: false
+         *     }
+         *   }
          * };
          *
          * report.updateSettings(newSettings)
diff --git a/dist/powerbi.js b/dist/powerbi.js
diff --git a/dist/powerbi.min.js b/dist/powerbi.min.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "powerbi-client",
-  "version": "2.17.1",
+  "version": "2.17.2",
   "description": "JavaScript library for embedding Power BI into your apps. Provides service which makes it easy to embed different types of components and an object model which allows easy interaction with these components such as changing pages, applying filters, and responding to data selection.",
   "main": "dist/powerbi.js",
   "types": "dist/powerbi-client.d.ts",
diff --git a/src/config.ts b/src/config.ts
@@ -1,6 +1,6 @@
 /** @ignore *//** */
 const config = {
-  version: '2.17.1',
+  version: '2.17.2',
   type: 'js'
 };
 
diff --git a/src/visual.ts b/src/visual.ts
@@ -232,7 +232,7 @@ export class Visual extends Report {
 
     const url: string = this.getFiltersLevelUrl(filtersLevel);
     try {
-      return await this.service.hpm.put<void>(url, updateFiltersRequest, { uid: this.config.uniqueId }, this.iframe.contentWindow);
+      return await this.service.hpm.post<void>(url, updateFiltersRequest, { uid: this.config.uniqueId }, this.iframe.contentWindow);
     } catch (response) {
       throw response.body;
     }

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "powerbi-client",`
`3`		`- "version": "2.17.1",`
	`3`	`+ "version": "2.17.2",`
`4`	`4`	`"description": "JavaScript library for embedding Power BI into your apps. Provides service which makes it easy to embed different types of components and an object model which allows easy interaction with these components such as changing pages, applying filters, and responding to data selection.",`
`5`	`5`	`"main": "dist/powerbi.js",`
`6`	`6`	`"types": "dist/powerbi-client.d.ts",`
Original file line number	Diff line number	Diff line change
`@@ -232,7 +232,7 @@ export class Visual extends Report {`
`232`	`232`
`233`	`233`	`const url: string = this.getFiltersLevelUrl(filtersLevel);`
`234`	`234`	`try {`
`235`		`- return await this.service.hpm.put<void>(url, updateFiltersRequest, { uid: this.config.uniqueId }, this.iframe.contentWindow);`
	`235`	`+ return await this.service.hpm.post<void>(url, updateFiltersRequest, { uid: this.config.uniqueId }, this.iframe.contentWindow);`
`236`	`236`	`} catch (response) {`
`237`	`237`	`throw response.body;`
`238`	`238`	`}`