Catch NullPointerException to avoid crash due to unsupported async disconnects on Android L (which uses an outdated okhttp version)

arthurpalves · danikula · commit 33b7e5e9d3e8 · 2015-12-08T18:59:37.000+03:00
diff --git a/library/src/main/java/com/danikula/videocache/HttpUrlSource.java b/library/src/main/java/com/danikula/videocache/HttpUrlSource.java
@@ -76,7 +76,13 @@ private int readSourceAvailableBytes(HttpURLConnection connection, int offset, i
     @Override
     public void close() throws ProxyCacheException {
         if (connection != null) {
-            connection.disconnect();
+            try {
+                connection.disconnect();
+            } catch (NullPointerException e) {
+                // https://github.com/danikula/AndroidVideoCache/issues/32
+                // https://github.com/danikula/AndroidVideoCache/issues/29
+                throw new ProxyCacheException("Error disconnecting HttpUrlConnection", e);
+            }
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,13 @@ private int readSourceAvailableBytes(HttpURLConnection connection, int offset, i`
`76`	`76`	`@Override`
`77`	`77`	`public void close() throws ProxyCacheException {`
`78`	`78`	`if (connection != null) {`
`79`		`- connection.disconnect();`
	`79`	`+ try {`
	`80`	`+ connection.disconnect();`
	`81`	`+ } catch (NullPointerException e) {`
	`82`	`+ // https://github.com/danikula/AndroidVideoCache/issues/32`
	`83`	`+ // https://github.com/danikula/AndroidVideoCache/issues/29`
	`84`	`+ throw new ProxyCacheException("Error disconnecting HttpUrlConnection", e);`
	`85`	`+ }`
`80`	`86`	`}`
`81`	`87`	`}`
`82`	`88`