Use the Python frame safely in _pythonCallstack (#88993) by charlie-wt · Pull Request #89997 · pytorch/pytorch · GitHub
Skip to content

Use the Python frame safely in _pythonCallstack (#88993) - #89997

Merged
atalman merged 1 commit into
pytorch:release/1.13from
charlie-wt:release/1.13-callstack
Dec 6, 2022
Merged

atalman merged 1 commit into
pytorch:release/1.13from
charlie-wt:release/1.13-callstack

Conversation

@charlie-wt

Copy link
Copy Markdown
Contributor

Link to landed master PR (if applicable):
#88993

Criteria category:
1: This prevents a crash, which was introduced here, tagged for 1.13
2: Prevents a crash

I'm hoping this is a low-risk change, since it's just changing one method for its safer form.

@pytorch-bot

pytorch-bot Bot commented Dec 1, 2022 •

Copy link
Copy Markdown

@pytorch-bot pytorch-bot Bot added the release notes: jit release notes category label Dec 1, 2022
@charlie-wt charlie-wt changed the title Use the Python frame safely in _pythonCallstack Use the Python frame safely in _pythonCallstack (#88993) Dec 1, 2022

@atalman atalman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atalman
atalman merged commit 59b4f3b into pytorch:release/1.13 Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open source release notes: jit release notes category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants