Converting alert type and app id to camel case in the CloudEvent by colerogers · Pull Request #1236 · firebase/firebase-functions · GitHub
Skip to content

Converting alert type and app id to camel case in the CloudEvent - #1236

Merged
colerogers merged 2 commits into
masterfrom
colerogers.fix-appid
Sep 20, 2022
Merged

colerogers merged 2 commits into
masterfrom
colerogers.fix-appid

Conversation

@colerogers

@colerogers colerogers commented Sep 19, 2022 •

Copy link
Copy Markdown
Contributor

Fixes a bug where the SDK expected camel cased fields, but eventarc did not, so we convert them before passing the event to the end users code.

@colerogers colerogers changed the title Converting alert type and app id to camel case in the CloudEvent for alerts Converting alert type and app id to camel case in the CloudEvent Sep 19, 2022
@colerogers
colerogers merged commit 65e66a2 into master Sep 20, 2022
@marcgovi

Copy link
Copy Markdown

@colerogers

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants