fix oauth session.destroy is undefined when use cookie-session package by fadiquader · Pull Request #2100 · feathersjs/feathers · GitHub
Skip to content

fix oauth session.destroy is undefined when use cookie-session package#2100

Merged
daffl merged 2 commits into
feathersjs:crowfrom
fadiquader:crow
Nov 8, 2020
Merged

fix oauth session.destroy is undefined when use cookie-session package#2100
daffl merged 2 commits into
feathersjs:crowfrom
fadiquader:crow

Conversation

@fadiquader

Copy link
Copy Markdown
Contributor

Hi @daffl
Oauth in our project suddenly broke, and it turned out that we use cookie-session for OAuth like so

const cookieSession = require('cookie-session');

  app.configure(expressOauth({
    expressSession: cookieSession({
      name: 'session',
      keys: ['grant'],
      maxAge: 60 * 1000
    })
  }));

that fixes OAuth when scaling the app Kubernetes. So now when trying to authenticate, it throws an error because cookie-session doesn't have destroy.
The bug is in authentication-oauth repo.

Thank you.

@daffl

daffl commented Oct 25, 2020

Copy link
Copy Markdown
Member

@fadiquader

Copy link
Copy Markdown
Contributor Author

@daffl You're right! Updated the PR.
Thanks

@daffl daffl merged commit 46e84b8 into feathersjs:crow Nov 8, 2020
@daffl

daffl commented Nov 8, 2020

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants