Message 208795 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Content 
Found two bugs in the draft patch in Objects/longobject.c:

1) In _PyLong_NullableIntConverter, there is no index variable, so the Py_DECREF and Py_XDECREF need to be removed from the end of the function.

2) In _PyLong_NullablePy_ssize_tConverter, the index variable will point to a Python object only when both if blocks are skipped. Therefore, the Py_XDECREF after "fail:" at the end of the function needs to be removed.

With these two changes, I successfully used this patch to convert deque_init in Modules/_collectionsmodule.c, simplifying the input validation code considerably.