Issue 4946: Lib/test/test__locale uses is to compare strings - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: benjamin.peterson, fijal, ggenellina
Priority: normal Keywords: patch

Created on 2009-01-14 10:54 by fijal, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
out.diff fijal, 2009-01-14 10:54
Messages (3)
msg79846 - (view) Author: Maciek Fijalkowski (fijal) Date: 2009-01-14 10:54 
this is at least a bad practice. It also might break silently at any point.
msg79879 - (view) Author: Gabriel Genellina (ggenellina) Date: 2009-01-14 22:24 
Yes, checking object identity is wrong in this case. Your patch looks 
fine to me.

I've found several other "is" comparisons that should not be there -- 
working on a patch right now.
msg79929 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2009-01-16 02:55 
Fixed in r68628.