Issue 4737: documentation and noddy*.c - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: georg.brandl Nosy List: benjamin.peterson, exe, georg.brandl
Priority: normal Keywords:

Created on 2008-12-24 14:26 by exe, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (2)
msg78260 - (view) Author: Kandalintsev Alexandre (exe) Date: 2008-12-24 14:26 
Hello!

1) In http://docs.python.org/3.0/extending/extending.html we see:
=========
Note that PyMODINIT_FUNC declares the function as void return type
=========

But thats not true, it's defined as PyObject*. I think this is outdated 
info in documentation.



2) In Doc/includes/noddy*.c assumed that PyMODINIT_FUNC returns nothing 
but this wrong. If you try "python3.1 -c 'import noddy'" you will see 
segfault. This patch will fix this problem:
--- ./noddy.c       2008-12-24 17:09:36.424870738 +0300
+++ ./noddy.c   2008-12-24 17:18:01.524869143 +0300
@@ -52,4 +52,6 @@
 
     Py_INCREF(&noddy_NoddyType);
     PyModule_AddObject(m, "Noddy", (PyObject *)&noddy_NoddyType);
+
+    return m;
 }


Other noddy*.c files are also requiring this patch.
msg78265 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2008-12-24 16:27 
Thanks for the report! Fixed in r67925.