Issue 45508: Specialize INPLACE_ADD - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
process
Status: closed Resolution: out of date
Dependencies: Superseder:
Assigned To: Nosy List: Dennis Sweeney
Priority: normal Keywords: patch

Created on 2021-10-18 09:49 by Dennis Sweeney, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 29024 closed Dennis Sweeney, 2021-10-18 09:50
Messages (1)
msg404171 - (view) Author: Dennis Sweeney (Dennis Sweeney) * (Python committer) Date: 2021-10-18 09:49 
I ran on WSL with PGO and got "1.00x faster":
https://gist.github.com/sweeneyde/41a76356e875e2a98d16ce5410ab41c0

My benchmarking doesn't seem particularly reliable, so someone else should probably verify.

Great specialization stats, except for telco, which uses decimal += decimal.

bm_fannkuch:
    inplace_add.specialization_success : 23
    inplace_add.specialization_failure : 3
    inplace_add.hit : 7968285
    inplace_add.deferred : 198
    inplace_add.miss : 39
    inplace_add.deopt : 3
    inplace_add.unquickened : 168

bm_nbody:
    inplace_add.specialization_success : 27
    inplace_add.specialization_failure : 3
    inplace_add.hit : 3600615
    inplace_add.deferred : 198
    inplace_add.miss : 39
    inplace_add.deopt : 3
    inplace_add.unquickened : 178

bm_spectral_norm:
    inplace_add.specialization_success : 24
    inplace_add.specialization_failure : 5
    inplace_add.hit : 2684690
    inplace_add.deferred : 326
    inplace_add.miss : 20843
    inplace_add.deopt : 3
    inplace_add.unquickened : 171

bm_telco:
    inplace_add.specialization_success : 21
    inplace_add.specialization_failure : 18537
    inplace_add.hit : 597
    inplace_add.deferred : 1186282
    inplace_add.miss : 39
    inplace_add.deopt : 3
    inplace_add.unquickened : 187