Issue 4542: test_binascii fails on windows - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: amaury.forgeotdarc
Priority: normal Keywords: easy, patch

Created on 2008-12-05 01:36 by amaury.forgeotdarc, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (2)
msg76963 - (view) Author: Amaury Forgeot d'Arc (amaury.forgeotdarc) * (Python committer) Date: 2008-12-05 01:36 
issue #4387 (67472) changed binascii and added tests, but the windows 
specific implementation was not changed. Change is trivial:

Index: Modules/binascii.c
===================================================================
--- Modules/binascii.c  (revision 67538)
+++ Modules/binascii.c  (working copy)
@@ -1019,7 +1019,7 @@
        Py_ssize_t len;
        unsigned int result;

-       if ( !PyArg_ParseTuple(args, "s*|I:crc32", &pbin, &crc) )
+       if ( !PyArg_ParseTuple(args, "y*|I:crc32", &pbin, &crc) )
                return NULL;
        bin_data = pbin.buf;
        len = pbin.len;
msg76964 - (view) Author: Amaury Forgeot d'Arc (amaury.forgeotdarc) * (Python committer) Date: 2008-12-05 01:42 
Fixed in r67541 (py3k) and r67542 (release30-maint)