➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2008-04-29 00:22 by brett.cannon, last changed 2022-04-11 14:56 by admin.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 19972 | open | furkanonder, 2020-05-07 00:12 | |
| Messages (9) | |||
|---|---|---|---|
| msg65948 - (view) | Author: Brett Cannon (brett.cannon) *  |
Date: 2008-04-29 00:22 | |
The audioop module contains a comment that is somewhat troubling from an IP standpoint: /* Code shamelessly stolen from sox, 12.17.7, g711.c ** (c) Craig Reese, Joe Campbell and Jeff Poskanzer 1989 */ Because of this it would be best to remove the current module and re- implement it from scratch (or remove it entirely). |
|||
| msg65952 - (view) | Author: Benjamin Peterson (benjamin.peterson) * |
Date: 2008-04-29 02:17 | |
I would support removing this in Py3k. It seems like a specialty module not worth having in the standard library. Also, is this even being maintained? |
|||
| msg66023 - (view) | Author: Georg Brandl (georg.brandl) * |
Date: 2008-04-30 20:20 | |
It is, as most "old" standard modules, not actively maintained, but there is always the chance that somebody will fix bugs as they are reported :) Anyway, the algorithms in it won't change, and if you want its removal I predict there will be many people crying out. |
|||
| msg105618 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2010-05-13 00:56 | |
I found severe bugs (which may lead to security vulnerabilities) in audioop: #7673. Nobody fixed these errors (but my issue contains a patch). |
|||
| msg112507 - (view) | Author: Georg Brandl (georg.brandl) * |
Date: 2010-08-02 18:18 | |
Current status: no lawsuit yet. |
|||
| msg170115 - (view) | Author: Aaron (hac.man) | Date: 2012-09-09 16:13 | |
The license from http://sox.sourcearchive.com/documentation/12.17.7/g711_8c-source.html /* * This source code is a product of Sun Microsystems, Inc. and is provided * for unrestricted use. Users may copy or modify this source code without * charge. * * SUN SOURCE CODE IS PROVIDED AS IS WITH NO WARRANTIES OF ANY KIND INCLUDING * THE WARRANTIES OF DESIGN, MERCHANTIBILITY AND FITNESS FOR A PARTICULAR * PURPOSE, OR ARISING FROM A COURSE OF DEALING, USAGE OR TRADE PRACTICE. * * Sun source code is provided with no support and without any obligation on * the part of Sun Microsystems, Inc. to assist in its use, correction, * modification or enhancement. * * SUN MICROSYSTEMS, INC. SHALL HAVE NO LIABILITY WITH RESPECT TO THE * INFRINGEMENT OF COPYRIGHTS, TRADE SECRETS OR ANY PATENTS BY THIS SOFTWARE * OR ANY PART THEREOF. * * In no event will Sun Microsystems, Inc. be liable for any lost revenue * or profits or other special, indirect and consequential damages, even if * Sun has been advised of the possibility of such damages. * * Sun Microsystems, Inc. * 2550 Garcia Avenue * Mountain View, California 94043 */ That seems compatible with Python's licensing, no? It seems like adding this license text to the file and also to the documentation in http://docs.python.org/license.html#licenses-and-acknowledgements-for-incorporated-software would make this a non-issue. Assessment of the module's contents and whether it should be rewritten or removed seems like a separate issue. I could write up a patch if people think that this would solve the problem. |
|||
| msg217675 - (view) | Author: Terry J. Reedy (terry.reedy) * |
Date: 2014-05-01 01:30 | |
Audioop was not removed in 3.x; the security bugs have been fixed; and no lawsuit. I agree with Aaron about modifying 2 files. I would also change 'shamelessly stolen' to 'taken'. IP is no longer something to joke about. |
|||
| msg241760 - (view) | Author: A.M. Kuchling (akuchling) * |
Date: 2015-04-22 00:16 | |
Van: what do you think? I can prepare a patch for Aaron's suggested changes. |
|||
| msg368316 - (view) | Author: Furkan Onder (furkanonder) * | Date: 2020-05-06 23:56 | |
PR has been sent. |
|||